build: remove deprecated Dockerfiles and scripts and update installation instructions #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
domire8
force-pushed
the
feat/install-script
branch
from
66d3fd2 to
5248774
Compare
|
This looks like a big PR but the review effort is not as high as the diff implicates. I deleted a lot of Dockerfiles and moved some existing README text from one file to another. |
eeberhard
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
this can always be patched after the release
Those are dangerous words 😅
Thanks for this and sorry for the late review. It was absolutely a case of "PR looks big, I will come back to it when I have time". But, overall not so massive changes and the streamlining of structure and readmes looks good to me 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Next step:
I think the installation instructions are maybe less verbose now but for the moment it should be enough and we want to encourage usage through docker anyway. Also, this can always be patched after the release.
Review guidelines
Estimated Time of Review: 10 minutes
Checklist before merging: