feat(components): get clproto message type from attribute #175
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One thing that has come to my attention with the recent documentation efforts and webinars is that the fact that we require the user to know the mapping between state representation type and the clproto message type when adding an output in python is a bit too much. I propose here in a non breaking fashion to remedy that by getting the clproto message type from the type of the class attribute. The functionality stays exactly the same (e.g. existing code still works and if a user wants to publish a CartesianPose as a CARTESIAN_STATE_MESSAGE, that is still possible), but for the simple case of the 1:1 mapping, the clproto message type is not required anymore to add an output.
Review guidelines
Estimated Time of Review: 5 minutes
Checklist before merging: