Reenable notebook tests #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielhollas
force-pushed
the
reenable-tests
branch
5 times, most recently
from
5e5a4c1 to
911ae64
Compare
danielhollas
commented
Oct 14, 2024
danielhollas
commented
Oct 14, 2024
There was a problem hiding this comment.
Copied almost verbatim from AWB, probably doesn't need to be reviewed
danielhollas
commented
Oct 14, 2024
Comment on lines
+81
to
+83
| if url_params is not None: | ||
| for key, value in url_params.items(): | ||
| url_with_token += f"&{key}={value}" |
yakutovicha
requested changes
Oct 21, 2024
There was a problem hiding this comment.
Thanks, @danielhollas!
I have only one question: why do you resize the window two times (see my comments below)? The rest seems to be alright.
danielhollas
force-pushed
the
reenable-tests
branch
from
33c8f1a to
8be78ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've taken the fixtures from AWB and modified the tests accordingly. The tests could certainly be improved, but this at least gets them running again.
Fixes #161. Staged on top of #176 (first commit)