Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make home notebook full width #182

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

edan-bainglass
Copy link
Member

Jupyter adds a max-width: calc(100% - 14ex) property settings to the output_subarea class, which is everywhere. This PR overwrites it with max-width: none to allow container widgets to take up the full width of the notebook.

Copy link
Contributor

@danielhollas danielhollas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this! ❤️

To illustrate, this is how my homepage look before this PR:
image

And after:
image

I do think that it would be very valuable to implement this in appmode directly. Let's discuss tomorrow if there's time.

CC @yakutovicha for visibility

Comment on lines +21 to +24
"metadata": {
"vscode": {
"languageId": "html"
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am somewhat surprised that the nbstripout pre-commit hook does not remove this. I guess it doesn't matter.

Comment on lines +31 to +33
" .output_subarea {\n",
" max-width: none !important;\n",
" }\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am going to trust you on this one. 😅

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I guess this is not that complicated, you're just ensuring that the max-width parameter is not set.

@danielhollas danielhollas merged commit 833d800 into aiidalab:main Nov 21, 2024
3 checks passed
@danielhollas
Copy link
Contributor

Actually, I do have one question here:

Jupyter adds a max-width: calc(100% - 14ex) property settings to the output_subarea class, which is everywhere.

What do you mean by "everywhere"?

@danielhollas danielhollas mentioned this pull request Nov 21, 2024
danielhollas added a commit to ispg-group/aiidalab-ispg that referenced this pull request Nov 28, 2024
This is the same fix as in aiidalab/aiidalab-home#182
Ultimately this this fix should be applied in AWB,
but for now we'll do it here.
danielhollas added a commit to ispg-group/aiidalab-ispg that referenced this pull request Nov 28, 2024
This is the same fix as in aiidalab/aiidalab-home#182
Ultimately this this fix should be applied in AWB,
but for now we'll do it here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants