-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make home notebook full width #182
Make home notebook full width #182
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love this! ❤️
To illustrate, this is how my homepage look before this PR:
I do think that it would be very valuable to implement this in appmode directly. Let's discuss tomorrow if there's time.
CC @yakutovicha for visibility
"metadata": { | ||
"vscode": { | ||
"languageId": "html" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am somewhat surprised that the nbstripout
pre-commit hook does not remove this. I guess it doesn't matter.
" .output_subarea {\n", | ||
" max-width: none !important;\n", | ||
" }\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am going to trust you on this one. 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I guess this is not that complicated, you're just ensuring that the max-width
parameter is not set.
Actually, I do have one question here:
What do you mean by "everywhere"? |
This is the same fix as in aiidalab/aiidalab-home#182 Ultimately this this fix should be applied in AWB, but for now we'll do it here.
This is the same fix as in aiidalab/aiidalab-home#182 Ultimately this this fix should be applied in AWB, but for now we'll do it here.
Jupyter adds a
max-width: calc(100% - 14ex)
property settings to theoutput_subarea
class, which is everywhere. This PR overwrites it withmax-width: none
to allow container widgets to take up the full width of the notebook.