Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the use of a static media port in a Connection #60

Closed
wants to merge 1 commit into from

Conversation

sirf
Copy link

@sirf sirf commented Sep 22, 2022

This makes it possible to run inside a docker container without a STUN/TURN server.

The issue with a randomly assigned port is that all ports must be published in advance when the container ls launched,

@jlaine
Copy link
Collaborator

jlaine commented Oct 16, 2022

In most use-cases (e.g. WebRTC) there are going to be multiple connections, how is this going to work?

@sirf
Copy link
Author

sirf commented Oct 16, 2022

In our use-case we do CPU/GPU intensive processing on the WebRTC media stream and need to scale the hardware infrastructure as the number of client grows, and we've decided to run one container per client hence the need to know which port to open beforehand. We're already running the proposed change and it works great.

That being said, the solution proposed in #47 seems more flexible and will cater for our use-case as well.

@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (b24214d) compared to base (f08956b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #60   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines         1184      1184           
=========================================
  Hits          1184      1184           
Impacted Files Coverage Δ
src/aioice/ice.py 100.00% <100.00%> (ø)
src/aioice/turn.py 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sirf
Copy link
Author

sirf commented Oct 26, 2022

This is a more flexible solution #63

@sirf sirf closed this Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants