Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 3D-Array to the Repo. #1029

Closed
wants to merge 15 commits into from

Conversation

harshbhardwaj000
Copy link

@harshbhardwaj000 harshbhardwaj000 commented Oct 19, 2024

📥 Pull Request

Description

as this repository work to collect information of different different algos so as a contributor i suppose to add 3D-array to the repository.

Fixes #907

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Great job, @harshbhardwaj000! Thank you for submitting your pull request. We appreciate your contribution, and our team will review it shortly.

Copy link

github-actions bot commented Oct 19, 2024

⚡️ Lighthouse Report for the Deploy Preview of this PR 🚀

🔗 Site: Algo | Live Site

URL 🌐 Performance Accessibility Best Practices SEO 📊
/algo/ 🔴 39 🟡 84 🟡 75 🟡 71 📄
/algo/docs 🔴 48 🟢 93 🟡 75 🟢 100 📄
/algo/blog 🟡 69 🟢 92 🟢 96 🟡 86 📄

@ajay-dhangar ajay-dhangar added gssoc-ext Contributions made as part of GirlScript Summer of Code Extended Edition. level1 GirlScript Summer of Code | Contributor's Levels labels Oct 20, 2024
Copy link
Owner

@ajay-dhangar ajay-dhangar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why you add .github/workflows/jekyll-gh-pages.yml can you delete

@harshbhardwaj000
Copy link
Author

sorry i mistakenly add it.
i will remove it

Copy link
Owner

@ajay-dhangar ajay-dhangar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content you need to write is in the docs folder, not outside of the docs folder. For example, docs/arrays/3D-Array.md.

@harshbhardwaj000
Copy link
Author

done. docs/basic-dsa/array/3D-Array.md

Copy link
Owner

@ajay-dhangar ajay-dhangar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to follow careful .md syntax because you are backed by some rules. If you don't follow the rules, your changes won't be accepted.

@harshbhardwaj000 harshbhardwaj000 closed this by deleting the head repository Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc-ext Contributions made as part of GirlScript Summer of Code Extended Edition. level1 GirlScript Summer of Code | Contributor's Levels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 3D array to the repo.
2 participants