-
-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
β [Idea]: KMP Algorithm for Pattern Searching #1360
β [Idea]: KMP Algorithm for Pattern Searching #1360
Conversation
@ajay-dhangar can you review this PR, and assign it to me with proper labels |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π Great job, @yashksaini-coder! Thank you for submitting your pull request. We appreciate your contribution, and our team will review it shortly.
β‘οΈ Lighthouse Report for the Deploy Preview of this PR π
|
@ajay-dhangar can you review this PR and add proper labels to it. |
@ajay-dhangar can you add |
@ajay-dhangar I closed the PR to resolve the merge conflicts, cleared the conflicts, you can review it now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update your code based on our format and syntax
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please follow the .jsx
and .mdx
syntax for this pull request. Our project uses markdown plus React, so this syntax is required.
@ajay-dhangar can you review this PR, and add hacktoberfest labels too |
@ajay-dhangar I have updated the code based on your specific requirements |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please recheck the code in your docs/KMP searching pattern/readme.md
file. The content is not good, and does not meet our guidelines. Please revise the content to be more meaningful.
I'm sorry for that, as it happens I had many PRs in your repo so am having problems in handling all, No worries I will update it later tomorrow. Also Happy Diwali π @ajay-dhangar |
@ajay-dhangar I have added implementation in different languages with step-by-step explanation, Hope this changes are good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
ππ Thank you for your contribution! Your PR #1360 has been merged! ππ |
π₯ Pull Request
Description
This pull request adds comprehensive documentation for the KMP (Knuth-Morris-Pratt) pattern searching algorithm. The changes include creating a new category for the KMP algorithm and adding a detailed README file that explains the algorithm, its implementation, and usage examples.
Documentation additions:
β Fixes #1343
Type of change
Checklist: