Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

βœ… [Idea]: KMP Algorithm for Pattern Searching #1360

Merged
merged 9 commits into from
Oct 31, 2024

Conversation

yashksaini-coder
Copy link
Contributor

πŸ“₯ Pull Request

Description

This pull request adds comprehensive documentation for the KMP (Knuth-Morris-Pratt) pattern searching algorithm. The changes include creating a new category for the KMP algorithm and adding a detailed README file that explains the algorithm, its implementation, and usage examples.

Documentation additions:

  • Created a new category for the KMP searching pattern with a description of the algorithm.
  • Added a detailed README file that includes an overview of the KMP algorithm, key features, how it works, implementation in Python, example usage, step-by-step example, performance comparison, common pitfalls, additional resources, and best practices.

βœ… Fixes #1343

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@yashksaini-coder
Copy link
Contributor Author

@ajay-dhangar can you review this PR, and assign it to me with proper labels

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸŽ‰ Great job, @yashksaini-coder! Thank you for submitting your pull request. We appreciate your contribution, and our team will review it shortly.

Copy link

github-actions bot commented Oct 27, 2024

⚑️ Lighthouse Report for the Deploy Preview of this PR πŸš€

πŸ”— Site: Algo | Live Site

URL 🌐 Performance Accessibility Best Practices SEO πŸ“Š
/algo/ 🟑 66 🟒 96 🟑 75 🟑 86 πŸ“„
/algo/docs 🟑 51 🟒 96 🟑 75 🟒 100 πŸ“„
/algo/blog 🟑 68 🟒 92 🟒 96 🟑 86 πŸ“„

@yashksaini-coder
Copy link
Contributor Author

@ajay-dhangar can you review this PR and add proper labels to it.

@ajay-dhangar ajay-dhangar added gssoc-ext Contributions made as part of GirlScript Summer of Code Extended Edition. level1 GirlScript Summer of Code | Contributor's Levels labels Oct 28, 2024
@yashksaini-coder
Copy link
Contributor Author

@ajay-dhangar can you add hacktoberfest labels too

@yashksaini-coder yashksaini-coder deleted the yash/fix-1343 branch October 28, 2024 13:59
@yashksaini-coder yashksaini-coder restored the yash/fix-1343 branch October 28, 2024 14:43
@yashksaini-coder
Copy link
Contributor Author

@ajay-dhangar I closed the PR to resolve the merge conflicts, cleared the conflicts, you can review it now.

Copy link
Owner

@ajay-dhangar ajay-dhangar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update your code based on our format and syntax

docs/KMP searching pattern/readme.md Show resolved Hide resolved
Copy link
Owner

@ajay-dhangar ajay-dhangar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the .jsx and .mdx syntax for this pull request. Our project uses markdown plus React, so this syntax is required.

docs/KMP searching pattern/readme.md Outdated Show resolved Hide resolved
@yashksaini-coder
Copy link
Contributor Author

@ajay-dhangar can you review this PR, and add hacktoberfest labels too

@yashksaini-coder
Copy link
Contributor Author

@ajay-dhangar I have updated the code based on your specific requirements

Copy link
Owner

@ajay-dhangar ajay-dhangar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please recheck the code in your docs/KMP searching pattern/readme.md file. The content is not good, and does not meet our guidelines. Please revise the content to be more meaningful.

@yashksaini-coder
Copy link
Contributor Author

Please recheck the code in your docs/KMP searching pattern/readme.md file. The content is not good, and does not meet our guidelines. Please revise the content to be more meaningful.

I'm sorry for that, as it happens I had many PRs in your repo so am having problems in handling all, No worries I will update it later tomorrow.

Also Happy Diwali πŸŽ† @ajay-dhangar

@yashksaini-coder
Copy link
Contributor Author

@ajay-dhangar I have added implementation in different languages with step-by-step explanation, Hope this changes are good

Copy link
Owner

@ajay-dhangar ajay-dhangar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@ajay-dhangar ajay-dhangar merged commit 48b9928 into ajay-dhangar:main Oct 31, 2024
5 checks passed
Copy link

πŸŽ‰πŸŽ‰ Thank you for your contribution! Your PR #1360 has been merged! πŸŽ‰πŸŽ‰

@yashksaini-coder yashksaini-coder deleted the yash/fix-1343 branch November 1, 2024 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc-ext Contributions made as part of GirlScript Summer of Code Extended Edition. level1 GirlScript Summer of Code | Contributor's Levels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Idea]: KMP Algorithm for Pattern Searching
2 participants