-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/php fixer #375
base: feature/php-fixer
Are you sure you want to change the base?
Feature/php fixer #375
Conversation
Added `passes_option` as a new package option to define php-cs-fixer options and fallback to phpf if `passes_option` is empty or not defined
Is it backward compatible with current config? |
I have not removed PS: sorry for replying this late |
added `delete=False` to NamedTemporaryFile() - fixes `Unable to read from <file>` error on Windows
@ashucg do you still use this package? |
@akalongman yes, I do |
@ashucg could you help to migrate PHP formatting part from phpF to PHP Code Fixer entirely? |
@akalongman sure, I can help with that. |
Hi @akalongman, I think I will have some spare time in December and I will finally get to work on migration part. I was thinking about creating predefined rules using a dictionary to map phpF options to php-cs-fixer and after formatting the code, tell users to check console output for recommended php-cs-fixer options which they can simply copy and add to their User Package Settings . This would help users to get a working installation without going through php-cs-fixer's available options just to get a similar configuration. Let me know your thoughts about the whole process. |
@ashucg I like your approach 👍 |
Added a new separate option to define PHP-CS-Fixer options/parameters allowing users to easily switch back to the former (phpF) if they want to
Example usage: