Fix compatibility with Gradle 4.6 #415
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gradle 4.6 introduced a `getJvmArgumentProviders` which it expects to never return `null`. If `null` is returned, then applying the `JacocoPluginExtension` fails.
|
In the long run I guess it would be better to have |
|
Here is the original report: https://discuss.gradle.org/t/gradle-4-6-rc1-is-now-available-for-testing/25864/3 |
|
Here is the stacktrace of the exception: |
|
@akhikhl Any feedback for this? Can this be merged, so the Gretty plugin works with Gradle 4.6? |
Closed
|
@wolfs just to clarify - this is a Gretty issue and occurred because it is using the Gradle internal task API, which is subject to change ... so this isn't considered an issue with Gradle 4.6? I think that's the case ... Out of interest, when you were in there ... did you notice whether it would be possible for Gretty to switch over to a public API for what it is doing there? I have to confess I have not looked. |
|
@javabrett The Gretty plugin is implementing an API which is not meant for implementation by using a Groovy Map. So yeah, that is not intended usage of the API. I added two suggestions how to solve the issue in #415 (comment). The first way would not involve any new public APIs. Maybe there is even a third way: The plugin could create a task (of e.g. type JavaExec) which is never executed and apply the plugin to this actual task instead of rely on mocking the right interfaces. |
This was referenced Feb 26, 2018
|
Fixes #420 |
henrik242
approved these changes
Feb 27, 2018
|
Hey @henrik242, do we have ETA when this PR will be merged and released? |
|
@chali Hi! It's merged at gretty-gradle-plugin#3 and the release is just around the corner: gretty-gradle-plugin#8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gradle 4.6 introduced a
getJvmArgumentProviderswhich it expects tonever return
null. Ifnullis returned, then applying theJacocoPluginExtensionfails.