[FEAT] Icon Component #30
Open
+34
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
jdic
reviewed
Nov 14, 2024
| "text-light-secondary dark:text-dark-secondary group-hover:text-light-text/60 dark:group-hover:text-dark-text/60" | ||
| )} | ||
| /> | ||
| <Icon icon={<UserCircleIcon />} /> |
There was a problem hiding this comment.
You forgot to put back the classes that already had the icon before.
Suggested change
| <Icon icon={<UserCircleIcon />} /> | |
| <Icon | |
| icon={<UserCircleIcon />} | |
| className={tw( | |
| "size-6 flex-shrink-0", | |
| "group-hover:text-light-text/60 dark:group-hover:text-dark-text/60" | |
| )} | |
| /> |
jdic
reviewed
Nov 14, 2024
| { "rotate-90": isOpen } | ||
| )} | ||
| /> | ||
| <Icon icon={ChevronRightIcon} className="w-4 h-4" /> |
There was a problem hiding this comment.
You forgot to put back the classes that already had the icon before.
Remember that you have to pass a created object, however, you are passing an unbuilt object, use < />.
Suggested change
| <Icon icon={ChevronRightIcon} className="w-4 h-4" /> | |
| <Icon | |
| icon={<ChevronRightIcon />} | |
| className={tw( | |
| "transition-transform duration-200", | |
| { "rotate-90": isOpen } | |
| )} | |
| /> |
jdic
reviewed
Nov 14, 2024
Comment on lines
+1
to
+21
| 'use client' | ||
|
|
||
| import { tw } from "@/lib/utils/tw"; | ||
| import { IconProps } from "@/types/templates"; | ||
| import React from "react"; | ||
|
|
||
| const Icon: React.FC<IconProps> = ({ className, icon }) => | ||
| { | ||
| return ( | ||
| <span | ||
| className={tw( | ||
| "font-bold size-4", | ||
| "text-light-text dark:text-dark-text", | ||
| className | ||
| )}> | ||
| {icon} | ||
| </span> | ||
| ); | ||
| } | ||
|
|
||
| export default Icon; |
There was a problem hiding this comment.
You must maintain a similar structure to the rest of the project, making use of ' when you are not in an HTML based structure and keep an order in the imports based on their size, also you must use a 2 spaces ident, not 4 spaces.
Suggested change
| 'use client' | |
| import { tw } from "@/lib/utils/tw"; | |
| import { IconProps } from "@/types/templates"; | |
| import React from "react"; | |
| const Icon: React.FC<IconProps> = ({ className, icon }) => | |
| { | |
| return ( | |
| <span | |
| className={tw( | |
| "font-bold size-4", | |
| "text-light-text dark:text-dark-text", | |
| className | |
| )}> | |
| {icon} | |
| </span> | |
| ); | |
| } | |
| export default Icon; | |
| 'use client' | |
| import { IconProps } from '@/types/templates' | |
| import { tw } from '@/lib/utils/tw' | |
| import React from 'react' | |
| const Icon: React.FC<IconProps> = ({ className, icon }) => | |
| { | |
| return ( | |
| <span | |
| className={tw( | |
| "size-4", | |
| "text-light-text dark:text-dark-text", | |
| className | |
| )}> | |
| {icon} | |
| </span> | |
| ) | |
| } | |
| export default Icon |
jdic
reviewed
Nov 14, 2024
Comment on lines
5
to
+8
| import { Generic } from '@/types/global' | ||
| import { tw } from '@/lib/utils/tw' | ||
| import React from 'react' | ||
| import Icon from '@/modules/common/templates/icon' |
There was a problem hiding this comment.
You must maintain an order in the imports based on their size.
jdic
requested changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.