Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix identification of OscillatorNode objects in Safari v14+. Fixes #146. #147

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jlyman
Copy link

@jlyman jlyman commented Oct 24, 2020

This adds a secondary identifier for checking that an object is an OscillatorNode, to be compatible with how WebKit (Safari) changed their object identifiers.

I ran the tests and they were all still green on Firefox. I additionally ran the tests on Safari (but did not change the karma.config.js file to include Safari because I assume that many others will not have Safari available for test). The suite on Safari failed 11 tests, but I was able to correct two of them which were directly linked to this issue. I didn't look into the other failures. Everything should still be green on FF however.

Fixes #146.

@jlyman jlyman marked this pull request as ready for review October 25, 2020 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Safari has issues with frequency get/set
1 participant