Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

提出 #164

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

提出 #164

wants to merge 4 commits into from

Conversation

igarisyu
Copy link

できました

nanashima
nanashima requested changes Jul 2, 2022
View reviewed changes
Copy link

@nanashima nanashima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spear.c works.c が正しく動いていません．

src/spear.c

unsigned int binary_search(int A[], int k, int n){
int sma = 0;
int big = arrayMax(A, n);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

初期値が不適切です．

src/works.c

unsigned int binary_search(int A[], int k, int n){
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

原因は特定していませんが，極端なケース
例えばn=100000 k=100000 全てのa_i = 1で正しく動いてないようです.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nanashima nanashima nanashima requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@igarisyu @nanashima