Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(search-account): copy index scope #706

Open
wants to merge 1 commit into
base: v3
Choose a base branch
from

Conversation

loicsay
Copy link
Contributor

@loicsay loicsay commented Oct 21, 2022

Q A
Bug fix? yes
New feature? no
BC breaks? no
Related Issue -
Need Doc update no

Describe your change

Taking scope into account to copy rules, synonyms and settings only when there's no scope. If one (or multiple) scope options are passed, copy the index depending on the parameters.

What problem is this fixing?

scope option passed to search.NewAccount().CopyIndex(...) is ignored.

@loicsay loicsay self-assigned this Oct 21, 2022
@loicsay loicsay force-pushed the fix/search-account-copy-index branch from 2298e24 to 1e3aeda Compare October 21, 2022 14:54
@loicsay loicsay force-pushed the fix/search-account-copy-index branch from 1e3aeda to 0adc702 Compare October 21, 2022 14:57
@loicsay loicsay added the Bug label Oct 21, 2022
@samouss
Copy link

samouss commented Oct 21, 2022

It looks like he scope option only exists for the search_client.copy_index function, but not for the account_client.copy_index. We may want to stick to the API client specs and avoid implementing a new option not present in other languages. I think @VladislavFitz may have an better view than me on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants