[Bug] miner_setMaxDASize should return bool type

[SangyunOck]

Motivation

op batcher prints error
ERROR[12-17|18:17:23.568] Result of SetMaxDASize was false, retrying.

command for op-bathcer

op-batcher \
  --l2-eth-rpc=http://localhost:8545 \
  --rollup-rpc=http://localhost:9545 \
  --poll-interval=1s \
  --sub-safety-margin=6 \
  --num-confirmations=1 \
  --safe-abort-nonce-too-low-count=3 \
  --resubmission-timeout=30s \
  --rpc.addr=0.0.0.0 \
  --rpc.port=8548 \
  --rpc.enable-admin \
  --max-channel-duration=25 \
  --l1-eth-rpc=$L1_RPC_URL \
  --private-key=$GS_BATCHER_PRIVATE_KEY

golang implementation of optimism's op-geth returns bool type for miner_setMaxDASize call. Therefore, expected response might be like following:

{
  "jsonrpc": "2.0",
  "id": 0,
  "result": true
}

On the other hand, current trait returns (), represents null for json.

pub trait MinerApiExt {
    /// Sets the maximum data availability size of any tx allowed in a block, and the total max l1
    /// data size of the block. 0 means no maximum.
    #[method(name = "setMaxDASize")]
    async fn set_max_da_size(&self, max_tx_size: U64, max_block_size: U64) -> RpcResult<()>; // should return bool
}

{
  "jsonrpc": "2.0",
  "id": 0,
  "result": null
}

ref: #325, #345

Solution

alter () to bool for return type

async fn set_max_da_size(&self, max_tx_size: U64, max_block_size: U64) -> RpcResult<bool>;

PR Checklist

• Added Tests
• Added Documentation
• Breaking changes

[mattsse]

-.-