Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor controller getContent #611

Open
wants to merge 37 commits into
base: develop
Choose a base branch
from
Open

Refactor controller getContent #611

wants to merge 37 commits into from

Conversation

Benjamin-Freoua-Alma
Copy link
Member

Reason for change

Linear task

Code changes

How to test

As a reviewer, you are encouraged to test the PR locally.

Checklist for authors and reviewers

  • The title of the PR uses business wording, not technical jargon, for the changelog readers to understand it
  • The PR implements the changes asked in the referenced task / issue
  • The automated tests are compliant with the testing strategy
  • The tests are relevant, and cover the corner/error cases, not only the happy path
  • You understand the impact of this PR on existing code/features
  • The changes include adequate logging and Datadog traces
  • Documentation is updated (API, developer documentation, ADR, Notion...)

Non applicable

Benjamin-Freoua-Alma and others added 12 commits November 22, 2024 10:39
@Benjamin-Freoua-Alma
feat: WIP - Handle Client and Api refacto for getContent
dcc453e
@Benjamin-Freoua-Alma
feat: handle the encrytpion to return empty apiKey if error
2730ad6
@Benjamin-Freoua-Alma
feat: refacto display standard form config before save
018ca4b
@Benjamin-Freoua-Alma
feat: Add configFormService for refacto display config form
353fc08
@Benjamin-Freoua-Alma
feat: add unit Test + refacto with HelperForm
914df66
@Benjamin-Freoua-Alma
feat: finalize test + add php doc comment
4c6ad25
@Benjamin-Freoua-Alma
feat: improve helperFormProxy with setter and getter
a2c5768
@Benjamin-Freoua-Alma
feat: add test for helperFormProxy and update test for ConfigFormService
0c1661f
@Benjamin-Freoua-Alma
feat: fix for sonar
395c312
@Benjamin-Freoua-Alma
feat: add test ClientModel + remove injection AlmaClient from controller
09a139a
@Benjamin-Freoua-Alma
Merge pull request #607 from alma/feature/ecom-2243-ps-handle-client-…
a9a4b43 
…and-api-refacto-for-getcontent

feat: Handle Client and Api refacto for getContent
@Benjamin-Freoua-Alma
feat: WIP - Handle configuration module to save and display the form
6d8ccce
@github-actions github-actions bot added the type: feature New feature label Dec 2, 2024
@Benjamin-Freoua-Alma Benjamin-Freoua-Alma changed the title Feature/ecom 2150 ps refactor controller getcontent Refactor controller getContent Dec 2, 2024
Benjamin-Freoua-Alma and others added 15 commits December 3, 2024 18:34
@Benjamin-Freoua-Alma
feat: WIP - save function form config
f014c30
@Benjamin-Freoua-Alma
feat: WIP - save function form config
c5598a0
@Benjamin-Freoua-Alma
feat: WIP - add test ShareOfCheckoutService
5c1f0f9
@Benjamin-Freoua-Alma
feat: add Soc Test + Save ApiKey + Test
b9a959f
@Benjamin-Freoua-Alma
feat: finalise saveConfiguration + test for pnxFormService and custom…
32877e0 
…FieldFormService
@Benjamin-Freoua-Alma
feat: add unit test for feeplans files
f631c3f
@Benjamin-Freoua-Alma
feat: fix clientModel + Fix unittest + manual test
884f23a
@Benjamin-Freoua-Alma
feat: handle notification first installation + begin fix insurance in…
a5fe7d2 
…stall
@joyet-simon
fix: resolve circular dependancies
064687c
@joyet-simon
fix: sonarcloud quality check
0b9a8ac
@Benjamin-Freoua-Alma
fix: review [SIM] Circular Dependency
14bd133
@Benjamin-Freoua-Alma
feat: add install insurance
afeb969
@Benjamin-Freoua-Alma
Merge pull request #608 from alma/feature/ecom-2244-ps-handle-configu…
982f0a0 
…ration-module-to-save-and-display-the-form

feat: Handle configuration module to save and display the form
@Benjamin-Freoua-Alma
feat: WIP add ps account - need test in CI
7884fe4
@Benjamin-Freoua-Alma
fix: ps account install for each case
42d30d2
@Benjamin-Freoua-Alma Benjamin-Freoua-Alma marked this pull request as ready for review January 2, 2025 19:15
@Benjamin-Freoua-Alma Benjamin-Freoua-Alma requested a review from a team as a code owner January 2, 2025 19:15
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025

⏳E2E tests are currently running.
➡️ You can follow their progression here.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 2, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
17.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025

❌ E2E tests have failed.
➡️ You can find the results here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Benjamin-Freoua-Alma @joyet-simon @webaaz