Return performance data as JSON #5336
Open
+37
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quis
force-pushed
the
performance-json
branch
from
e8691c7 to
44cf916
Compare
leohemsted
reviewed
Dec 23, 2024
app/main/views/performance.py
Outdated
| stats["average_percentage_under_10_seconds"] = mean( | ||
| [row["percentage_under_10_seconds"] for row in stats["processing_time"]] or [0] | ||
| ) | ||
| stats["count_of_live_services_and_organisations"] = status_api_client.get_count_of_live_services_and_organisations() | ||
|
|
||
| if request.endpoint == "main.json": |
There was a problem hiding this comment.
should this not be:
Suggested change
| if request.endpoint == "main.json": | |
| if request.endpoint == "main.performance_json": |
(nb: i haven't run this locally to test)
There was a problem hiding this comment.
Fixed now and added a rudimentary test that would have caught this
We don’t display this publicly on the page any more, so we don’t want to expopse it publicly in the JSON output.
quis
force-pushed
the
performance-json
branch
from
44cf916 to
345bfd3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like this when running locally:
{ "average_percentage_under_10_seconds": 0, "count_of_live_services_and_organisations": { "organisations": 1, "services": 48 }, "email_notifications": 15, "letter_notifications": 0, "live_service_count": 48, "notifications_by_type": [], "organisations_using_notify": [ { "count_of_live_services": 47, "organisation_name": "Department for Social Affairs and Citizenship" }, { "count_of_live_services": 1, "organisation_name": "No organisation" } ], "processing_time": [], "sms_notifications": 47, "total_notifications": 62 }