chore: replace kubebuilder kube-rbac-proxy #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreddedbacon
force-pushed
the
kube-rbac-proxy
branch
from
ebe4d08 to
2124ffb
Compare
shreddedbacon
force-pushed
the
kube-rbac-proxy
branch
from
2124ffb to
f4a95af
Compare
|
I'm going to merge this. I've been running the aergia controller in our test infrastructure with this image and everything is still working as expected with metrics. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since kubebuilder announced the deprecation and removal of their
kube-rbac-proxyimage in #56 , this is an interim solution to usebitnami/kube-rbac-proxyinstead.The bitnami image while being a newer version of the kube-rbac-proxy, still functions the same way (with a few deprecation notices of flags). This will give us time to transition away from having to use it.
Some benefits to this are that this bitnami image is multi-arch.