Added possibility to select slice when converting MultiDimensionalArray to an EigenMatrix #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ay to an EigenMatrix
…y to a eigen matrix. Added test
S-Dafarra
force-pushed
the
add_slices_eigen
branch
from
3ba574b to
4c791d7
Compare
xela-95
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Thanks a lot @S-Dafarra !! By a first look it seems good to me! I left some minor comments related to the example used in documentation and test.
Co-authored-by: Alessandro Croci <[email protected]>
|
Great catch @xela-95, thanks a lot! |
|
Actually, also the test was bugged and I realized I was missing some checks. Fixing them soon |
xela-95
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #88