Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward Cancellation in ConnectionLimitingServerSocket #377

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

Fneufneu
Copy link
Contributor

Looks like someone forgot to forward the cancellation to the accept method.

@kelunik
Copy link
Member

kelunik commented Dec 31, 2024

Thanks! The commit isn't associated with your GitHub account. Can you double check the author email, please?

@Fneufneu Fneufneu force-pushed the clss_forward_cancel branch from e63d2b8 to 89da125 Compare December 31, 2024 15:26
@Fneufneu
Copy link
Contributor Author

oops, fixed

@trowski trowski merged commit c60cde9 into amphp:3.x Dec 31, 2024
6 checks passed
@trowski
Copy link
Member

trowski commented Dec 31, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants