-
Notifications
You must be signed in to change notification settings - Fork 961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Draft]: Feat: granular access control Pre-RFC demo #2029
Open
xfiderek
wants to merge
11
commits into
amundsen-io:main
Choose a base branch
from
xfiderek:feat/accesscontrol
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xfiderek
changed the title
Feat/accesscontrol
[Draft]: Feat: granular access control Pre-RFC demo
Nov 12, 2022
Golodhros
added
rfc
Indicates that there is an RFC associated with this issue.
type:feature
A new feature request
and removed
category:api
labels
Dec 15, 2022
@xfiderek what's the status of this work? |
hey @Golodhros. I've created formal RFC as discussed: amundsen-io/rfcs#49 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:frontend
From the Frontend folder
keep fresh
Disables stalebot from closing an issue
rfc
Indicates that there is an RFC associated with this issue.
type:feature
A new feature request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This is a draft PR with demo of proposed granular access control model for amundsen.
*For more details, please refer to the following slack message
As soon as concept is approved on slack, I will fix formatting and code coverage - please treat this PR as a demo
Tests
Currently only metadata endpoint is tested, as it was only endpoint modified. Classes are not tested yet. After initial approval of the concept, other tests will be implemented
Documentation
There is almost no documentation - refer to slack message linked above
CheckList
Make sure you have checked all steps below to ensure a timely review.