Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update databuilder docs ES version reference #2049

Merged
merged 1 commit into from
Dec 15, 2022
Merged

docs: Update databuilder docs ES version reference #2049

merged 1 commit into from
Dec 15, 2022

Conversation

bryanasdev000
Copy link
Contributor

@bryanasdev000 bryanasdev000 commented Dec 8, 2022 •
edited
Loading

Summary of Changes

Per #1722 and #1386, databuilder seems to already supports ES 8.x, but there is no mention in requirements.txt.

Should close #2050.

Tests

Documentation

Specify ES 7.x as supported per actual requirements.txt.

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

@bryanasdev000 bryanasdev000 requested a review from a team as a code owner December 8, 2022 20:06
@boring-cyborg boring-cyborg bot added area:databuilder From databuilder folder area:all Related to all the project area:docs labels Dec 8, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Dec 8, 2022

Congratulations on your first Pull Request and welcome to Amundsen community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/amundsen-io/amundsen/blob/main/CONTRIBUTING.md)

@bryanasdev000 bryanasdev000 mentioned this pull request Dec 8, 2022
Closed
@bryanasdev000
docs: Update databuilder docs ES version reference
afbdc39 
Per https://github.com/amundsen-io/amundsen/pull/1722/files and https://github.com/amundsen-io/amundsen/pull/1386/files, databuilder seems to already supports ES 8.x, but there is no mention in requirements.txt

Signed-off-by: Bryan A. S <[email protected]>
@Golodhros Golodhros added type:documentation A documentation improvement task and removed area:docs labels Dec 15, 2022
Golodhros
Golodhros approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@Golodhros Golodhros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bryanasdev000
Copy link
Contributor Author

Forgot to add, but this should close #2050.

@Golodhros
Copy link
Member

Forgot to add, but this should close #2050.

Thanks!

@Golodhros Golodhros merged commit 546add2 into amundsen-io:main Dec 15, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Dec 15, 2022

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Golodhros Golodhros Golodhros approved these changes

Assignees
No one assigned
Labels
area:all Related to all the project area:databuilder From databuilder folder area:dev-tools area:docs type:documentation A documentation improvement task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Specify elasticsearch supported version
2 participants
@bryanasdev000 @Golodhros