-
Notifications
You must be signed in to change notification settings - Fork 961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: preview environments for every PR using Uffizzi #2051
base: main
Are you sure you want to change the base?
Conversation
Congratulations on your first Pull Request and welcome to Amundsen community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/amundsen-io/amundsen/blob/main/CONTRIBUTING.md) |
cc @Golodhros |
Hi @waveywaves, thank you for integrating this! In terms of the question of test data, I know the Quick Start steps outline how to include some sample data - would it be possible to include the same here? |
I don't have any context on the use case or the product. So need to defer to others to review |
This allows us to have a private URL where we see the changes introduced by a PR in real live! |
dbcc8f3
to
a46ddf8
Compare
@Golodhros It will be a public URL :) |
Signed-off-by: Vibhav Bobade <[email protected]>
@kristenarmes Thank you for the tip. I have created a dockerfile which will help us build the databuilder-init image which we can use to initialize the db with some data. Although, I am facing a problem during it's build. Getting a |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Happy New year team ! @Golodhros let me know if these changes make sense. And let me know if this works for you. #2051 (comment) how can I solve this problem |
Hi @Golodhros - friendly ping. I discussed this with @waveywaves and just wanted to check in and see if Preview Environments for every PR is something you want. If not we can close out the PR |
Hi @jpthurman, this is definitely something we want to have! The problem is that the team at Lyft is really busy these days and I don't have the skills to help you solve that issue. I will keep on pinging other maintainers to see if they can help! Thanks for your patience! |
Thanks for the reply @Golodhros I think this can be solved in a short zoom call. Can you set up a time with right person within Lyft? |
Makes sense! |
Summary of Changes
Add github workflow which builds the amundsend metadata, search and frontend images from the PR branch and uses them to create a preview environment on Uffizzi.
A PoC of this PR has been done here
After this PR is merged, all the subsequent PRs to this repo will have preview environments deployed with a link to the preview posted to the PR like this
The preview created in the above PR can be accessed here https://app.uffizzi.com/github.com/waveywaves/amundsen/pull/1
fixes #2040
Tests
Documentation
CheckList
Make sure you have checked all steps below to ensure a timely review.