Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing where clause issue in redshift_metadata_extractor #2217

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

amrshindhe
Copy link

Leading whitespaces causing errors with startsWith() python method, so using lstrip() before starts with will resolve the error

@amrshindhe amrshindhe requested a review from a team as a code owner November 30, 2023 06:54
@boring-cyborg boring-cyborg bot added the area:databuilder From databuilder folder label Nov 30, 2023
Copy link
Contributor

@kristenarmes kristenarmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a small suggestion for the change, and in addition to that you had one failing test and need to sign your commit(s) and then should be good to go

Comment on lines +32 to 33
where_clause_suffix = where_clause_suffix.lstrip()
if where_clause_suffix.lower().startswith("where"):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for making the change, I would suggest including it on the same line to make it cleaner

Suggested change
where_clause_suffix = where_clause_suffix.lstrip()
if where_clause_suffix.lower().startswith("where"):
if where_clause_suffix.lstrip().lower().startswith("where"):

Copy link

stale bot commented Dec 15, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Dec 15, 2023
@Alagappan
Copy link
Contributor

ping @amarshinde150 any updates on this one?

@stale stale bot removed the stale label Mar 26, 2024
@Alagappan Alagappan mentioned this pull request Mar 26, 2024
4 tasks
Copy link

stale bot commented Apr 22, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:databuilder From databuilder folder stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants