Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependencies updated, build fixed. #30

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Dependencies updated, build fixed. #30

wants to merge 9 commits into from

Conversation

syslogic
Copy link

No description provided.

@omeryounus
Copy link

@syslogic Just out of curiosity why do we need to format it??

@syslogic
Copy link
Author

syslogic commented Oct 25, 2019 •
edited
Loading

R.string.sets_format is the one formatted text in the header, eg. Sets: 1/6. While the lack of the attribute formatted="false" prevented the build, because it rejected the (otherwise) positional format %d/%d. Without that exclusion, it won't process the resources - or generate class BR.

@syslogic
Copy link
Author

syslogic commented Oct 25, 2019 •
edited
Loading

I've fixed the reference to class BR, which closes #27 & probably #28. Also fixed most Gradle & Lint warnings.

@syslogic syslogic changed the title Dependencies updated, TwoWaySample build fixed. Dependencies updated, build fixed. Oct 25, 2019
@codingjeremy codingjeremy changed the base branch from master to main September 29, 2020 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omeryounus omeryounus omeryounus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@syslogic @omeryounus