Ensure declarative boot order doesn't influence initrd flash script #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Including the DTBO used for configuring the boot order in the initrd flash script means that the temporary edk2 build used only for flashing has the possibility of booting from something other than the kernel/initrd meant for flashing. Excluding this DTBO when performing the initrd flash method means that this is no longer possible.
The `initrd=` kernel command-line argument is used by the EFI stub to determine where to pickup the initrd from an ESP. Since in the RCM boot case there is no ESP, it doesn't make sense to specify it here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Including the DTBO used for configuring the boot order in the initrd flash script means that the temporary edk2 build used only for flashing has the possibility of booting from something other than the kernel/initrd meant for flashing. Excluding this DTBO when performing the initrd flash method means that this is no longer possible.
Testing
Tested on an xavier-agx-devkit that was previously netbooting when attempting to use the initrd flash script.