Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: CMake #37

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

WIP: CMake #37

wants to merge 15 commits into from

Conversation

loriab
Copy link

@loriab loriab commented Nov 14, 2018

build and install probably ok (though I wouldn't be surprised if omp not propagating. detection and use untested except for pymod in psi4.

Copy link
Owner

@andysim andysim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some really great cleanup in here: thank you so much for all the hard work. This looks like a far more elegant build ecosystem than the previous version. This is a very good demonstration of the power of interfaces in CMake, and I'm learning a lot by looking at the changes. I'm going to pull it to my laptop and our cluster to test before merging, but this looks really great :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants