This repository has been archived by the owner on Dec 4, 2017. It is now read-only.
style-guide(add-a11y): Add accessibility quick wins #1854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlmeroSteyn
force-pushed
the
styleguide-a11y
branch
2 times, most recently
from
298fffa to
51a166a
Compare
| +makeExample('style-guide/ts/10-01/app/index.avoid.html', 'page-lang', 'index.html')(avoid=1) | ||
|
|
||
| :marked | ||
| Provide the ISO language code as well the country code (where appropriate). |
There was a problem hiding this comment.
We are not putting messages between avoid and do (correct me if I am wrong). We could put that as a Consider
There was a problem hiding this comment.
Seems like we do. Let's hold on this and see if we can do better.
AlmeroSteyn
force-pushed
the
styleguide-a11y
branch
8 times, most recently
from
36b8027 to
8043eee
Compare
AlmeroSteyn
force-pushed
the
styleguide-a11y
branch
from
8043eee to
062c4b9
Compare
|
|
||
| .s-rule.avoid | ||
| :marked | ||
| **Avoid** totaly removing the focus outline on your page. |
There was a problem hiding this comment.
Now it's completely fixed.
AlmeroSteyn
force-pushed
the
styleguide-a11y
branch
from
062c4b9 to
4c0cecc
Compare
|
@Foxandxss: There is one flow issue now, because of number |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding accessibility recommendations to style guide.
These are all quick accessibility wins making use of HTML and CSS alone and requiring no use of ARIA.