Skip to content
This repository has been archived by the owner on Dec 4, 2017. It is now read-only.

docs(cookbook) Custom exception handler service cookbook. #2112

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bennadel
Copy link
Contributor

This cookbook demonstrates how to override the core ExceptionHandler class
with a custom service class that both logs to the console as well as sending
errors to a robust error-logginer service. This error-logging service can,
in turn, send errors to the server; or, to Software-as-a-Service (SaaS)
products like New Relic, TrackJS, and Raygun.

This cookbook demonstrates how to override the core `ExceptionHandler` class
with a custom service class that both logs to the console as well as sending
errors to a robust error-logginer service. This error-logging service can,
in turn, send errors to the server; or, to Software-as-a-Service (SaaS)
products like New Relic, TrackJS, and Raygun.
@Foxandxss Foxandxss force-pushed the ben-cb-exception-handler branch from 7dd5ed8 to ade77e8 Compare August 28, 2016 19:31
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

1 similar comment
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@Foxandxss
Copy link
Member

What was the problem with the e2e here?

@bennadel
Copy link
Contributor Author

bennadel commented Sep 4, 2016

@Foxandxss the fact that the UI stops updating after an error is thrown. As such, I couldn't capture the error and then update the UI and then test the UI in the e2e tests. It seems that the only way to test might be to use non-standard testing. So, for now, I'm just testing to make sure nothing blows up.

@zoechi
Copy link

zoechi commented Sep 12, 2016

@bennadel from what I have seen this is because change detection doesn't run after an exception. Can't you invoke change detection manually? (I don't know NG2/TS testing well).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants