Allow logging in with an access token #155
Conversation
gabrc52
changed the title
There was a problem hiding this comment.
Thank you for this contribution. It looks like a good addition, though I've yet to try it out.
Please add some documentation about how to obtain an access token.
I foresee one possible issue, namely that certain access tokens need to get refreshed. We need to communicate that those are not supported, how to check if a token will need to get refreshed, and document how to obtain one that does not need refreshing. https://spec.matrix.org/latest/client-server-api/#refreshing-access-tokens
| # The public URL at which the homeserver's Client-Server API can be accessed | ||
| homeserver_url: https://example.com | ||
| # The device ID that is a **non pre-existing** device | ||
| # If this device ID already exists, messages will be dropped silently in | ||
| # encrypted rooms | ||
| # (if using token login type, request the token with this device_id) |
There was a problem hiding this comment.
see above. the wording should be adjusted accordingly, like "only used with password; ignored in favor of existing device id with token login". also the existing description only really fits the password login, so i think we need to reword the whole thing.
| logger.fatal("your access_token is likely wrong") | ||
| return False | ||
|
|
||
| assert whoami_response.device_id == CONFIG.device_id |
There was a problem hiding this comment.
Should this fail hard? What happens if the "wrong" device_id would be passed to AsyncClient? What do you think about setting
CONFIG.device_id = whoami_response.device_id
instead and printing a warning?
For instance, in homeservers which only support single-sign-on, logging in with an access token is useful