Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hard coding of choices of category in change_request #322

Merged
merged 4 commits into from
Mar 19, 2024

Conversation

tupyy
Copy link
Contributor

@tupyy tupyy commented Mar 19, 2024

This PR removes the hard coding of choices of category and allows mapping for the category so user can provide custom values

SUMMARY

Fixes #266

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

change_request

This commit removes the hard coding of choices of category and allows
mapping for category so user can provide custom values
@tupyy tupyy requested a review from Akasurde March 19, 2024 15:52
Copy link
Member

@Akasurde Akasurde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

changelogs/fragments/change_request_category.yml Outdated Show resolved Hide resolved
plugins/modules/change_request.py Outdated Show resolved Hide resolved
@tupyy
Copy link
Contributor Author

tupyy commented Mar 19, 2024

@Akasurde could take a look at sanity checks please. It's saying something about documentation but I have no idea why it's complaining

Copy link

Copy link

@tupyy tupyy merged commit 97cf659 into ansible-collections:main Mar 19, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

category is limited for change_request module.
2 participants