feat: Add support for Tron #1258

Likang0122 · 2024-11-21T10:00:06Z

💡 Background and solution

Add support for Tron

🔗 Related issue link

vercel · 2024-11-21T10:00:11Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
ant-design-web3	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 19, 2024 5:56am

changeset-bot · 2024-11-21T10:00:11Z

🦋 Changeset detected

Latest commit: 267c262

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@ant-design/web3-tron	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2024-11-21T10:00:17Z

socket-security · 2024-11-21T10:00:54Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher

🚮 Removed packages: npm/@tanstack/[email protected], npm/@tanstack/[email protected], npm/@tanstack/[email protected], npm/@testing-library/[email protected], npm/@tiplink/[email protected], npm/@tonconnect/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected]

View full report↗︎

yutingzhao1991 · 2024-11-26T07:30:13Z

packages/web3/src/tron/demos/components/signMessage.tsx

@@ -0,0 +1,38 @@
+import React, { useState } from 'react';


这个文件夹下两个组件的大小写不一致，统一为大驼峰吧

yutingzhao1991 · 2024-11-26T07:32:19Z

packages/tron/README.md

@@ -0,0 +1 @@
+# @ant-design/web3-tron


readme 简单写一个

参考 https://github.com/ant-design/ant-design-web3/blob/main/packages/solana/README.md

yutingzhao1991 · 2024-11-26T07:33:02Z

packages/tron/package.json

@@ -0,0 +1,67 @@
+{
+  "name": "@ant-design/web3-tron",
+  "version": "1.0.0",


这个改为 0.0.1，新增一个 changlog，然后发布的时候就会发布为 1.0.0 版本

yutingzhao1991 · 2024-11-26T07:35:54Z

packages/tron/src/index.ts

+export * from './provider';
+export * from './wallets/types';
+export * from './wallets/okxTronWallet';
+export { useWallet } from '@tronweb3/tronwallet-adapter-react-hooks';


这个里面都有些什么 hooks？如果是我们依赖了 @tronweb3/tronwallet-adapter-react-hooks 这个，但是又需要暴露给用户用，是不是把 @tronweb3/tronwallet-adapter-react-hooks 中的内容全部通过 @ant-design/web3-tron/hooks 暴露出去？

可以讨论一下。

yutingzhao1991 · 2024-11-26T07:37:38Z

packages/web3/src/tron/demos/basic.tsx

@@ -0,0 +1,14 @@
+import { ConnectButton, Connector } from '@ant-design/web3';
+import { okxTronWallet, tronWallets, TronWeb3ConfigProvider } from '@ant-design/web3-tron';


tronWallets 是复数？

yutingzhao1991 · 2024-11-26T07:39:22Z

packages/web3/src/tron/index.zh-CN.md

+<code src='./demos/message.tsx'></code>
+
+## Sign Transaction
+


文档 API 补充一下

github-actions · 2024-11-26T10:26:12Z

🚨 @Likang0122, 本次 PR 的更改包含 major 变更，请确认是否符合预期。

🚨 @Likang0122, this PR contains major changes, please confirm if it is as expected.

+'@ant-design/web3-tron': major

thinkasany · 2024-11-26T12:33:02Z

packages/icons/src/index.ts

@@ -77,6 +77,7 @@ export * from './components/bitcoin-circle-colorful';
 export * from './components/bitcoin-circle-filled';
 export * from './components/bitcoin-colorful';
 export * from './components/bitcoin-filled';
+export * from './components/bitget-wallet-colorful';


感觉 icon 单独抽一个 pr 比较好，会让这个 pr review 起来更加轻松，变更文件更少。之前也都是这么做的。

thinkasany · 2024-11-26T12:35:38Z

packages/tron/README.md

@@ -0,0 +1 @@
+# @ant-design/web3-tron


参考 https://github.com/ant-design/ant-design-web3/blob/main/packages/solana/README.md

thinkasany · 2024-11-26T12:38:33Z

packages/tron/src/wallets/types.ts

+// import type { Wallet, WalletMetadata } from '@ant-design/web3-common';
+
+// export interface WalletFactory {
+//   create: () => Wallet;
+// }
+
+// export type WalletFactoryBuilder = (metadata: WalletMetadata) => WalletFactory;
+


Suggested change

// import type { Wallet, WalletMetadata } from '@ant-design/web3-common';

// export interface WalletFactory {

// create: () => Wallet;

// }

// export type WalletFactoryBuilder = (metadata: WalletMetadata) => WalletFactory;

下面好像有了是不是没用了

codecov · 2024-12-19T06:04:54Z

Codecov Report

Attention: Patch coverage is 11.39241% with 210 lines in your changes missing coverage. Please review.

Project coverage is 98.58%. Comparing base (e0db15a) to head (267c262).
Report is 5 commits behind head on main.

Files with missing lines	Patch %	Lines
packages/tron/src/provider/config-provider.tsx	0.00%	103 Missing ⚠️
packages/tron/src/provider/index.tsx	0.00%	32 Missing ⚠️
packages/tron/src/wallets/bitgetWallet.tsx	0.00%	21 Missing ⚠️
packages/tron/src/wallets/bybitWallet.tsx	0.00%	21 Missing ⚠️
packages/tron/src/wallets/tronlinkWallet.tsx	0.00%	20 Missing ⚠️
packages/tron/src/wallets/okxTronWallet.tsx	0.00%	6 Missing ⚠️
packages/tron/src/wallets/index.ts	0.00%	4 Missing ⚠️
packages/tron/src/utils.ts	0.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1258      +/-   ##
==========================================
- Coverage   99.99%   98.58%   -1.41%     
==========================================
  Files         858      869      +11     
  Lines       14726    14963     +237     
  Branches     1589     1599      +10     
==========================================
+ Hits        14725    14752      +27     
- Misses          1      211     +210

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

vercel bot had a problem deploying to Preview November 21, 2024 10:01 Failure

vercel bot had a problem deploying to Preview November 22, 2024 10:13 Failure

yutingzhao1991 reviewed Nov 26, 2024

View reviewed changes

github-actions bot added the major label Nov 26, 2024

vercel bot had a problem deploying to Preview November 26, 2024 10:27 Failure

vercel bot had a problem deploying to Preview November 26, 2024 10:48 Failure

thinkasany reviewed Nov 26, 2024

View reviewed changes

vercel bot had a problem deploying to Preview November 27, 2024 08:32 Failure

vercel bot had a problem deploying to Preview December 2, 2024 07:58 Failure

vercel bot had a problem deploying to Preview December 2, 2024 09:09 Failure

Likang0122 added 10 commits December 3, 2024 14:25

feat: Add Tronlink icon

e3a8b5c

feat: Add support for Tron

5b70091

fix: del

4a04171

feat: add sign message&transaction

a7a34b1

chore: add wallet icons

8e39ff8

chore: more wallet

91443f8

chore: add readme

7b5b900

fix: rename

d1bb1b3

chore: add test

297d3e8

fix: readme

7e411fb

Likang0122 force-pushed the wutian_dev branch from 132f9b8 to 7e411fb Compare December 3, 2024 07:03

vercel bot had a problem deploying to Preview December 3, 2024 07:04 Failure

fix: reinstall

7081afd

vercel bot deployed to Preview December 5, 2024 06:46 View deployment

fix: required

a0171bc

vercel bot deployed to Preview December 5, 2024 06:52 View deployment

Likang0122 added 2 commits December 6, 2024 10:38

chore: add

42ba08f

fix: test

4248d6e

vercel bot deployed to Preview December 16, 2024 08:08 View deployment

fix: del test

267c262

vercel bot deployed to Preview December 19, 2024 05:56 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add support for Tron #1258

feat: Add support for Tron #1258

Likang0122 commented Nov 21, 2024

vercel bot commented Nov 21, 2024 •

edited

Loading

changeset-bot bot commented Nov 21, 2024 •

edited

Loading

github-actions bot commented Nov 21, 2024 •

edited

Loading

socket-security bot commented Nov 21, 2024 •

edited

Loading

yutingzhao1991 Nov 26, 2024

yutingzhao1991 Nov 26, 2024

thinkasany Nov 26, 2024

yutingzhao1991 Nov 26, 2024

yutingzhao1991 Nov 26, 2024

yutingzhao1991 Nov 26, 2024

yutingzhao1991 Nov 26, 2024

github-actions bot commented Nov 26, 2024 •

edited

Loading

thinkasany Nov 26, 2024

thinkasany Nov 26, 2024

thinkasany Nov 26, 2024

thinkasany Nov 26, 2024

codecov bot commented Dec 19, 2024

		@@ -0,0 +1,14 @@
		import { ConnectButton, Connector } from '@ant-design/web3';
		import { okxTronWallet, tronWallets, TronWeb3ConfigProvider } from '@ant-design/web3-tron';

feat: Add support for Tron #1258

Are you sure you want to change the base?

feat: Add support for Tron #1258

Conversation

Likang0122 commented Nov 21, 2024

💡 Background and solution

🔗 Related issue link

vercel bot commented Nov 21, 2024 • edited Loading

changeset-bot bot commented Nov 21, 2024 • edited Loading

🦋 Changeset detected

github-actions bot commented Nov 21, 2024 • edited Loading

socket-security bot commented Nov 21, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Nov 26, 2024 • edited Loading

🚨 @Likang0122, 本次 PR 的更改包含 major 变更，请确认是否符合预期。

🚨 @Likang0122, this PR contains major changes, please confirm if it is as expected.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Dec 19, 2024

Codecov Report

vercel bot commented Nov 21, 2024 •

edited

Loading

changeset-bot bot commented Nov 21, 2024 •

edited

Loading

github-actions bot commented Nov 21, 2024 •

edited

Loading

socket-security bot commented Nov 21, 2024 •

edited

Loading

github-actions bot commented Nov 26, 2024 •

edited

Loading