Contructors, examples #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The update introduces a benchmark actor that receives messages and increments a message counter. It also includes the creation of a new protobuf message. The main function is updated to incorporate this benchmark actor, while providing a detailed simulation of sending messages across multiple actors distributed across different engines.
The benchmark code is refactored for better error handling and message checks. 'benchmark' function is extracted from 'main' for further testing. A new Makefile target 'bench-profile' is added for profiling. A new test file 'main_test.go' is created for benchmark testing. Corresponding instructions are added in the newly created README.md file. Also, .gitignore is updated to exclude the created test, cpu, and memory profiles.
…d it out. Gonna revisit latency benchmarks later.
The benchmark command in the Makefile has been updated to run the whole package, not just main.go
|
@perbu I merged the remote examples first, which conflicts here apparantly |
|
Don't worry about it. I'll fix it on my end.
…On Wed, Dec 20, 2023 at 12:12 PM Anthony De Meulemeester < ***@***.***> wrote:
@perbu <https://github.com/perbu> I merged the remote examples first,
which conflicts here apparantly
—
Reply to this email directly, view it on GitHub
<#120 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABYZWN5IANDSZLJ26PFYB3YKLB2TAVCNFSM6AAAAABA4RTAFOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRUGI4TEMJZHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@anthdm conflicts resolved. ready to merge. |
|
oh. I need to fix the README again. |
|
Let me know if you are happy with the README, I will merge after. |
|
Now it should be good. benchmark also fixed and the output is shown in the readme. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, I changed the engine and remote constructor according to #114.
So now these are consistent. I'll do the cluster too, but maybe in another PR as this one is already quite big.
I've also fixed all the remote examples, including the mdns-example, which was completely broken. It's actually quite cool.
Hopefully this should be one of the last breaking changes we'll do.