Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redis dependency #140

Merged
merged 2 commits into from
Dec 30, 2023
Merged

Remove redis dependency #140

merged 2 commits into from
Dec 30, 2023

Conversation

perbu
Copy link
Collaborator

@perbu perbu commented Dec 30, 2023

This PR removes the redis depency by altering the persistence example to use file storage instead.

@perbu
Copy link
Collaborator Author

perbu commented Dec 30, 2023

This closes #68 .

@ValentinMontmirail
Copy link
Contributor

Well isn't the question more: why are dependencies from examples listed inside the official go.mod of the repo? There is no other way to avoid that than simply not using Redis in examples?

@tprifti
Copy link
Contributor

tprifti commented Dec 30, 2023

Well isn't the question more: why are dependencies from examples listed inside the official go.mod of the repo? There is no other way to avoid that than simply not using Redis in examples?

You could create go.mod inside the examples but the issue is that each example will need to sync with latest version of hollywood version each time there is a new release.

@anthdm anthdm merged commit 54133c9 into anthdm:master Dec 30, 2023
1 check passed
@perbu
Copy link
Collaborator Author

perbu commented Dec 30, 2023

Well isn't the question more: why are dependencies from examples listed inside the official go.mod of the repo? There is no other way to avoid that than simply not using Redis in examples?

If you take a look at the linked issue there is some discussion there. The least worst alternative was to remove the dependencies.

@perbu perbu deleted the noredise branch December 30, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants