Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Reworking the event stream so its also an actor #79

Merged
merged 5 commits into from
Dec 3, 2023

Conversation

anthdm
Copy link
Owner

@anthdm anthdm commented Dec 3, 2023

No description provided.

@anthdm anthdm requested a review from perbu December 3, 2023 13:45
@perbu
Copy link
Collaborator

perbu commented Dec 3, 2023

the design looks good. where do you wanna take it from here? you've opened a can of worms with this. do you wanna finish it and keep the PR open or merge right away? if we merge it now others could likely finish up the missing bits.

Copy link
Collaborator

@perbu perbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with merging it. it is unfinished but I don't mind master being a bit rough around the edges.

@anthdm
Copy link
Owner Author

anthdm commented Dec 3, 2023

@perbu We can add more events to it later. Will merge.

@anthdm anthdm merged commit 2098fc6 into master Dec 3, 2023
2 checks passed
@anthdm anthdm deleted the evenstream-rework branch December 3, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants