feat: update cors rules in google-anyscale-cloudstorage module #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With some upcoming changes to the front-end, Anyscale has additional changes for the CORS rules for the Google Cloud Storage bucket. On branch brent/update-cors Changes to be committed: modified: modules/google-anyscale-cloudstorage/README.md modified: modules/google-anyscale-cloudstorage/variables.tf
Additional change to the default variable used in the root module for setting CORS settings in the google-anyscale-cloudstorage submodule. Changes to be committed: modified: README.md modified: test/anyscale-v2-e2e-public-test/main.tf modified: variables.tf
github-actions
bot
added
documentation
brent-anyscale
added
enhancement
Additional changes for the CORS policy for Google Cloud Storage to support additional functionality for the Anyscale UI including the new dependency functionality for Anyscale Clusters. Changes to be committed: modified: README.md modified: modules/google-anyscale-cloudstorage/README.md modified: modules/google-anyscale-cloudstorage/variables.tf modified: variables.tf
hckuo
approved these changes
Feb 6, 2024
brent-anyscale
changed the title
README includes additional cleanup and new image from documentation. CHANGELOG includes latest version release notes Changes to be committed: modified: CHANGELOG.md modified: README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With some upcoming changes to the front-end, Anyscale has additional
changes for the CORS rules for the Google Cloud Storage bucket.
On branch brent/update-cors
Changes to be committed:
modified: modules/google-anyscale-cloudstorage/README.md
modified: modules/google-anyscale-cloudstorage/variables.tf
modified: README.md
modified: test/anyscale-v2-e2e-public-test/main.tf
modified: variables.tf
Pull request checklist
Please check if your PR fulfills the following requirements:
Pull Request Type
Does this introduce a breaking change?