fix: Firewall port assignment was not correct #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firewall Port Assignments were not properly getting pulled in, leaving all TCP Ports open. upd: CloudStorage to a member instead of binding for IAM policies. Changed from `bucket_iam_member_override_roles` to `bucket_iam_member_additional_roles` Changes to be committed: modified: .pre-commit-config.yaml modified: README.md modified: main.tf modified: modules/google-anyscale-cloudstorage/README.md modified: modules/google-anyscale-cloudstorage/examples/README.md modified: modules/google-anyscale-cloudstorage/examples/main.tf modified: modules/google-anyscale-cloudstorage/main.tf deleted: modules/google-anyscale-cloudstorage/test/README.md deleted: modules/google-anyscale-cloudstorage/test/terraform_google_anyscale_cloudstorage_test.go modified: modules/google-anyscale-cloudstorage/variables.tf deleted: modules/google-anyscale-project/test/README.md deleted: modules/google-anyscale-project/test/terraform_google_anyscale_project_test.go modified: modules/google-anyscale-vpc-firewall/main.tf deleted: modules/google-anyscale-vpc/test/terraform_google_anyscale_vpc_test.go new file: test/anyscale-service/socket_test.py modified: variables.tf
brent-anyscale
added
enhancement
github-actions
bot
added
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firewall Port Assignments were not properly getting pulled in, leaving all TCP Ports open.
upd: CloudStorage to a member instead of binding for IAM policies. Changed from
bucket_iam_member_override_rolestobucket_iam_member_additional_rolesChanges to be committed:
modified: .pre-commit-config.yaml
modified: README.md
modified: main.tf
modified: modules/google-anyscale-cloudstorage/README.md
modified: modules/google-anyscale-cloudstorage/examples/README.md
modified: modules/google-anyscale-cloudstorage/examples/main.tf
modified: modules/google-anyscale-cloudstorage/main.tf
deleted: modules/google-anyscale-cloudstorage/test/README.md
deleted: modules/google-anyscale-cloudstorage/test/terraform_google_anyscale_cloudstorage_test.go
modified: modules/google-anyscale-cloudstorage/variables.tf
deleted: modules/google-anyscale-project/test/README.md
deleted: modules/google-anyscale-project/test/terraform_google_anyscale_project_test.go
modified: modules/google-anyscale-vpc-firewall/main.tf
deleted: modules/google-anyscale-vpc/test/terraform_google_anyscale_vpc_test.go
new file: test/anyscale-service/socket_test.py
modified: variables.tf
Pull request checklist
Please check if your PR fulfills the following requirements:
Pull Request Type
Does this introduce a breaking change?