Skip to content

Commit

Permalink
upd: Support latest changes for Anyscale Operator on GCP
Browse files Browse the repository at this point in the history
On branch brent/gke-standard-public
Changes to be committed:
	modified:   README.md
	modified:   main.tf
	modified:   outputs.tf
  • Loading branch information
brent-anyscale committed Nov 8, 2024
1 parent e52abb7 commit fe4f3f5
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 8 deletions.
4 changes: 2 additions & 2 deletions examples/gcp/gke-existing_cluster/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@ existing_gke_cluster_region = "..."

| Name | Version |
|------|---------|
| <a name="provider_google"></a> [google](#provider\_google) | 5.44.1 |
| <a name="provider_kubernetes"></a> [kubernetes](#provider\_kubernetes) | 2.32.0 |
| <a name="provider_google"></a> [google](#provider\_google) | 5.44.2 |
| <a name="provider_kubernetes"></a> [kubernetes](#provider\_kubernetes) | 2.33.0 |

## Modules

Expand Down
12 changes: 9 additions & 3 deletions examples/gcp/gke-existing_cluster/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -21,16 +21,22 @@ locals {
)
}

#trivy:ignore:AVD-GCP-0011
module "anyscale_iam" {
#checkov:skip=CKV_TF_1: Example code should use the latest version of the module
#checkov:skip=CKV_TF_2: Example code should use the latest version of the module
source = "github.com/anyscale/terraform-google-anyscale-cloudfoundation-modules//modules/google-anyscale-iam"
module_enabled = true

anyscale_org_id = var.anyscale_org_id
create_anyscale_access_role = true
create_anyscale_access_role = false
create_anyscale_access_service_acct = true
create_anyscale_cluster_node_service_acct = true # Set to true to bind to a GKE Service Account
anyscale_cluster_node_service_acct_name = "anyscale-cluster-node"
anyscale_cluster_node_service_acct_name = "anyscale-dataplane-node"
anyscale_cluster_node_service_acct_permissions = [
"roles/iam.serviceAccountTokenCreator",
"roles/artifactregistry.reader"
]

anyscale_project_id = var.google_project_id
}
Expand All @@ -42,7 +48,7 @@ module "anyscale_cloudstorage" {
module_enabled = true

bucket_iam_members = [
module.anyscale_iam.iam_anyscale_access_service_acct_member,
# module.anyscale_iam.iam_anyscale_access_service_acct_member,
module.anyscale_iam.iam_anyscale_cluster_node_service_acct_member
]

Expand Down
3 changes: 0 additions & 3 deletions examples/gcp/gke-existing_cluster/outputs.tf
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,7 @@ output "anyscale_registration_command" {
--cloud-storage-bucket-name ${module.anyscale_cloudstorage.cloudstorage_bucket_name} \
--filestore-instance-id ${module.anyscale_filestore.anyscale_filestore_name} \
--filestore-location ${module.anyscale_filestore.anyscale_filestore_location} \
--anyscale-service-account-email ${module.anyscale_iam.iam_anyscale_access_service_acct_email} \
--provider-name ${module.anyscale_iam.iam_workload_identity_provider_name} \
--kubernetes-namespaces ${var.anyscale_k8s_namespace} \
--kubernetes-ingress-external-address ${module.anyscale_k8s_helm.nginx_ingress_lb_ips[0]} \
--kubernetes-zones ${join(",", data.google_container_cluster.anyscale.node_locations)} \
--anyscale-operator-iam-identity ${module.anyscale_iam.iam_anyscale_cluster_node_service_acct_email}
EOT
Expand Down

0 comments on commit fe4f3f5

Please sign in to comment.