Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add QC CSV final output, fix weird or incorrect QC filters #42

Merged
merged 17 commits into from
Nov 9, 2023
Merged

Conversation

aofarrel
Copy link
Owner

@aofarrel aofarrel commented Nov 9, 2023

  • Adds a new task to output QC metrics to a LIMS-compatible file
  • Flips tbprofilerQC_max_pct_unmapped into tbprofilerQC_min_pct_mapped, which is more intuitive
  • More consistent variable names throughout, and a very basic style guide
  • neoTBfastProfiler now filters based on the percentage of reads above q30 AFTER filtering with fastp instead of BEFORE. If filtering is not performed, this value falls back on the value measured BEFORE filtering in order to keep the QC stuff working as expected.
  • Decontam defaults to 32 GB now

@aofarrel aofarrel merged commit b1e63eb into main Nov 9, 2023
1 check passed
@aofarrel aofarrel deleted the qc_csv branch November 9, 2023 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant