Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Support property: maven.compiler.release for building BK with higher version JDK #4090

Closed
wants to merge 3 commits into from
Closed

[Build] Support property: maven.compiler.release for building BK with higher version JDK #4090

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
672bf14
[Build] Support property: maven.compiler.release for building BK with…
Reidddddd Sep 26, 2023
483c4e4
fix issue when using maven-javadoc-plugin under --release tag
Reidddddd Sep 27, 2023
7b5c29d
remove unnecessary changes
Reidddddd Sep 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions bookkeeper-common/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,11 +135,10 @@
<sourcepath>${src.dir}</sourcepath>
<!-- Avoid for missing javadoc comments to be marked as errors -->
<doclint>none</doclint>
<subpackages>org.apache.bookkeeper.common.annotation</subpackages>
<groups>
<group>
<title>Bookkeeper Client</title>
<packages>org.apache.bookkeeper.common.annotation*</packages>
<packages>org.apache.bookkeeper.common.annotation</packages>
</group>
</groups>
</configuration>
Expand Down
2 changes: 2 additions & 0 deletions bookkeeper-common/src/main/java/org/apache/bookkeeper/common/conf/ConfigKey.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@
@Slf4j
public class ConfigKey {

public static class ConfigKeyBuilder {}

public static final Comparator<ConfigKey> ORDERING = (o1, o2) -> {
int ret = Integer.compare(o1.orderInGroup, o2.orderInGroup);
if (ret == 0) {
Expand Down
2 changes: 2 additions & 0 deletions bookkeeper-common/src/main/java/org/apache/bookkeeper/common/conf/ConfigKeyGroup.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@
@Public
public class ConfigKeyGroup {

public static class ConfigKeyGroupBuilder {}

/**
* Ordering the key groups in a configuration.
*/
Expand Down
3 changes: 1 addition & 2 deletions bookkeeper-server/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,11 +294,10 @@
<sourcepath>${src.dir}</sourcepath>
<!-- Avoid for missing javadoc comments to be marked as errors -->
<doclint>none</doclint>
<subpackages>org.apache.bookkeeper.client:org.apache.bookkeeper.conf:org.apache.bookkeeper.feature</subpackages>
<groups>
<group>
<title>Bookkeeper</title>
<packages>org.apache.bookkeeper*</packages>
<packages>org.apache.bookkeeper.client:org.apache.bookkeeper.conf:org.apache.bookkeeper.feature</packages>
</group>
</groups>
</configuration>
Expand Down
3 changes: 2 additions & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
<javac.target>1.8</javac.target>
<release.target>8</release.target>
<redirectTestOutputToFile>true</redirectTestOutputToFile>
<testRetryCount>2</testRetryCount>
<src.dir>src/main/java</src.dir>
Expand Down Expand Up @@ -963,7 +964,6 @@
<notimestamp>true</notimestamp>
<!-- Prevent missing javadoc comments from being marked as errors -->
<doclint>none</doclint>
<subpackages>org.apache.bookkeeper.client:org.apache.bookkeeper.client.api:org.apache.bookkeeper.common.annotation:org.apache.bookkeeper.conf:org.apache.bookkeeper.feature:org.apache.bookkeeper.stats</subpackages>
<groups>
<group>
<title>Bookkeeper Client</title>
Expand Down Expand Up @@ -1273,6 +1273,7 @@
<jdk>[11,)</jdk>
</activation>
<properties>
<maven.compiler.release>${release.target}</maven.compiler.release>
<test.additional.args>
--add-opens java.base/java.io=ALL-UNNAMED
--add-opens java.base/java.lang=ALL-UNNAMED
Expand Down
1 change: 0 additions & 1 deletion stats/bookkeeper-stats-api/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@
<sourcepath>${src.dir}</sourcepath>
<!-- Avoid for missing javadoc comments to be marked as errors -->
<doclint>none</doclint>
<subpackages>org.apache.bookkeeper.stats</subpackages>
<groups>
<group>
<title>Bookkeeper Stats API</title>
Expand Down
Loading