Cleanup layoutManager null-check when AbstractZkLedgerManagerFactory#newLedgerManagerFactory #4124
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descriptions of the changes in this PR:
Motivation
Remove the null-check from
AbstractZkLedgerManagerFactory#newLedgerManagerFactory
. The reason is that:layoutManager
innewLedgerManagerFactory()
method can never be null. So this check is unnecessorylayoutManager
is null and we returnnew FlatLedgerManagerFactory().initialize(conf, null, FlatLedgerManagerFactory.CUR_VERSION)
, the 'zk' inFlatLedgerManagerFactory
is null and could throw NPE when invoke the methods in theFlatLedgerManagerFactory
.Changes
newLedgerManagerFactory()
layoutManager
could never be null inFlatLedgerManagerFactory