[BP-62] LedgerHandle introduces batch read API. #4195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
reviewed
Feb 2, 2024
| * the total entries count. | ||
| * @param maxSize | ||
| * the total entries size. | ||
| * @param failbackToSingleRead |
There was a problem hiding this comment.
Shouldn't we always want to fallback, when the server does not support the feature?
There was a problem hiding this comment.
That makes sense, we should always failback to single read when the batch read is not supported.
There was a problem hiding this comment.
I will remove the failbackToSingleRead flag.
merlimat
approved these changes
Feb 4, 2024
hangc0276
approved these changes
Feb 5, 2024
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
### Motivation This is the fifth PR for the batch read(apache#4051) feature. LedgerHandle introduces batch read API. This PR is based on apache#4190, please merge it firstly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is the fifth PR for the batch read(#4051) feature.
LedgerHandle introduces batch read API.
This PR is based on #4190, please merge it firstly.