-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix duplicate artifacts issue with maven-source-plugin in release build #4237
Conversation
- fixes error "The packaging plugin for this project did not assign a main file to the project but it has attachments."
@eolivelli @nicoloboschi This is also needed in branch-4.16 and branch-4.15 since those are also broken due to pom.xml changed made while fixing integration tests. Please also include #4235 and #4236. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
thank you very much!
This reverts commit 89d1d58.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Motivation
dev/release/003-release-perform.sh fails with errors
After resolving that, there was another set of errors in installing
bookkeeper-dist/all
,bookkeeper-dist/bkctl
andbookkeeper-dist/server
. The error message contained this message:Changes
jar-no-fork
goal instead ofjar
goal.bookkeeper-dist/all
,bookkeeper-dist/bkctl
andbookkeeper-dist/server
The packaging plugin for this project did not assign a main file to the project but it has attachments.