Fix potential class conflict during jetcd-core-shaded shading process #4532
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This a make up patch for #4526, which missed the root cause to fix potential jetcd-core shading problem.
Because the
maven-shade-plugin
includes the current project artifact during the shade process. Injetcd-core-shaded
, we copyio.etcd.jetcd.*
into thejetcd-core-shaded
jar without relocation. As a result, when theinstall
ordeploy
goals are executed without cleaning thetarget
folder, class conflicts arise betweenio.etcd.jetcd.*
insideorg.apache.bookkeeper.metadata.drivers:jetcd-core-shaded.jar
andio.etcd:jetcd-core.jar
.Verifying this Change
To verify this patch, follow these steps: