Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

method level option to ignore server eovercrowded #2820

Merged
merged 9 commits into from
Dec 4, 2024

Conversation

superhail
Copy link
Contributor

What problem does this PR solve?

Issue Number:

Problem Summary:

What is changed and the side effects?

Changed: add a method-level option(only valid for baidu_rpc, http_rpc, hulu_pbrpc and sofa_pbrpc protocols) to enable ignore eovercrowded errors for some methods.

Side effects:

  • Performance effects(性能影响): no or little

  • Breaking backward compatibility(向后兼容性):


Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

src/brpc/policy/baidu_rpc_protocol.cpp Outdated Show resolved Hide resolved
src/brpc/policy/http_rpc_protocol.cpp Outdated Show resolved Hide resolved
src/brpc/policy/hulu_pbrpc_protocol.cpp Outdated Show resolved Hide resolved
src/brpc/policy/sofa_pbrpc_protocol.cpp Outdated Show resolved Hide resolved
src/brpc/baidu_master_service.h Outdated Show resolved Hide resolved
src/brpc/server.h Outdated Show resolved Hide resolved
src/brpc/server.h Outdated Show resolved Hide resolved
Copy link
Contributor

@chenBright chenBright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以补充一下server.md文档吗?

@superhail
Copy link
Contributor Author

好的,我补充一下

Copy link
Contributor

@chenBright chenBright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@superhail
Copy link
Contributor Author

@wwbmmm please help review

src/brpc/baidu_master_service.h Outdated Show resolved Hide resolved
src/brpc/server.h Outdated Show resolved Hide resolved
@superhail
Copy link
Contributor Author

@wwbmmm cc

@wwbmmm
Copy link
Contributor

wwbmmm commented Dec 3, 2024

LGTM

@chenBright chenBright merged commit f187d2c into apache:master Dec 4, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants