[CELEBORN-1797] Support to adjust the logger level with RESTful API during runtime #3022
+1,004
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turboFei
changed the title
turboFei
changed the title
|
LGTM, Thanks @turboFei , change log level at runtime is very useful for debugging. |
RexXiong
approved these changes
Dec 23, 2024
FMX
reviewed
Dec 23, 2024
| @@ -456,6 +456,44 @@ paths: | |||
| type: string | |||
| format: binary | |||
|
|
|||
| /api/v1/logger: | |||
There was a problem hiding this comment.
This PR is amazing, can you provide an API to list all logger names since we don't know the logger names?
There was a problem hiding this comment.
Using loggerContext.getConfiguration.getLoggers instead of loggerContext.getLoggers.
There was a problem hiding this comment.
loggerContext.getConfiguration.getLoggers is reasonable.
It only return the configured logger, including the items in the config file and changed by POST /api/v1/loggers.
celeborn/common/src/test/resources/log4j2-test.xml
Lines 31 to 40 in 680b072
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support to adjust the logger level during runtime without restarting the server.
Why are the changes needed?
It is useful for debug, likes hadoop daemonlog command: https://hadoop.apache.org/docs/r3.4.1/hadoop-project-dist/hadoop-common/CommandsManual.html#daemonlog
Does this PR introduce any user-facing change?
Yes, new RESTful api.
How was this patch tested?
GA.
