[browser] Move check for showSplashScreen outside of showAndHide #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, unless AutoHideSplashScreen is enabled in the config, not showing the splash screen is ignored altogether.
janpio
reviewed
Oct 31, 2018
janpio
reviewed
Oct 31, 2018
| @@ -138,13 +138,11 @@ function readPreferencesFromCfg(cfg) { | |||
| * Shows and hides splashscreen if it is enabled, with a delay according the current preferences. | |||
| */ | |||
| function showAndHide() { | |||
There was a problem hiding this comment.
Is this possibly used somewhere else?
Or could this be used externally so someone could depend on the broken behavior?
There was a problem hiding this comment.
Its certainly possible that someone externally uses this and depends on the broken behavior. The only way to avoid that for certain would be to keep the if in this function and then also check for enabled in the caller when autohide is disabled.
Co-Authored-By: bytenik <[email protected]>
janpio
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, unless AutoHideSplashScreen is enabled in the config, not showing the splash screen is ignored altogether.
Platforms affected
Browser
What does this PR do?
Properly doesn't show the splash on Browser when
ShowSplashScreenis false, even if you do not setAutoHideSplashScreento true.What testing has been done on this change?
Verified that plugin works as expected.