Skip to content

Commit

Permalink
Add comment and move tests
Browse files Browse the repository at this point in the history
  • Loading branch information
viirya committed Mar 11, 2024
1 parent eab49f6 commit d67edc8
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -382,6 +382,7 @@ class CometSparkSessionExtensions
case None => b
}

// For AQE shuffle stage on a Comet shuffle exchange
case s @ ShuffleQueryStageExec(_, _: CometShuffleExchangeExec, _) =>
val newOp = transform1(s)
newOp match {
Expand All @@ -391,6 +392,9 @@ class CometSparkSessionExtensions
s
}

// For AQE shuffle stage on a reused Comet shuffle exchange
// Note that we don't need to handle `ReusedExchangeExec` for non-AQE case, because
// the query plan won't be re-optimized/planned in non-AQE mode.
case s @ ShuffleQueryStageExec(
_,
ReusedExchangeExec(_, _: CometShuffleExchangeExec),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -926,6 +926,12 @@ class CometAsyncShuffleSuite extends CometColumnarShuffleSuite {
override protected val asyncShuffleEnable: Boolean = true

protected val adaptiveExecutionEnabled: Boolean = true
}

class CometShuffleSuite extends CometColumnarShuffleSuite {
override protected val asyncShuffleEnable: Boolean = false

protected val adaptiveExecutionEnabled: Boolean = true

import testImplicits._

Expand Down Expand Up @@ -976,12 +982,6 @@ class CometAsyncShuffleSuite extends CometColumnarShuffleSuite {
}
}

class CometShuffleSuite extends CometColumnarShuffleSuite {
override protected val asyncShuffleEnable: Boolean = false

protected val adaptiveExecutionEnabled: Boolean = true
}

class DisableAQECometShuffleSuite extends CometColumnarShuffleSuite {
override protected val asyncShuffleEnable: Boolean = false

Expand Down

0 comments on commit d67edc8

Please sign in to comment.