feat: Support Binary in shuffle writer #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure why this issue doesn't happen before... Seems like binary data are already used in various shuffle suites. |
viirya
reviewed
Feb 24, 2024
Comment on lines
+318
to
+320
| // TODO: this is not accurate, but should be good enough for now | ||
| DataType::Binary => len * 100 + len * 4, | ||
| DataType::LargeBinary => len * 100 + len * 8, |
viirya
reviewed
Feb 24, 2024
core/src/execution/datafusion/shuffle_writer/shuffle_writer_test.rs
Outdated
Show resolved
Hide resolved
They use columnar shuffle, I think, which has much more coverage. |
I see. Thanks, let me try to add a test case in the spark side that leverages native shuffle. |
Fixed. Please let me know that whether we should put test code in the shuffle_writer.rs or in a different file. |
|
The TPCDS CI pipeline failure is going to be fixed at #108. |
|
Merged, thanks! |
himadripal
pushed a commit
to himadripal/datafusion-comet
that referenced
this pull request
Sep 7, 2024
Force using the provided Comet version by purging previous snapshots from the local repository. This avoids inadvertently picking up the wrong snapshot. This only occurs if `dev/install-comet-spark.sh` is explicitly provided a Comet version to use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #105
Rationale for this change
bug fixes
What changes are included in this PR?
Add binary pattern matching in shuffle_writer.rs
How are these changes tested?
Add new test cases in rust and spark side