Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add license header by spotless:apply automatically #110

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

advancedxy
Copy link
Contributor

Which issue does this PR close?

Closes #.

Rationale for this change

Add corresponding license header automatically, so developers doesn't need to bother that.

What changes are included in this PR?

  1. spotless plugin changes to include scala/java license
  2. spotless:apply to the existing code

How are these changes tested?

manual verification

@@ -17,13 +17,6 @@
* under the License.
*/

/**
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to the class header. Otherwise it would be stripped off by spotless:apply for license header formating

@advancedxy
Copy link
Contributor Author

I noticed that java/scala license header is not added by spotless when developing CometCollectLimitExec. So submit this PR to add it automatically.

cc @sunchao @viirya

Copy link
Member

@sunchao sunchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sunchao sunchao merged commit f359ed7 into apache:main Feb 26, 2024
15 checks passed
@sunchao
Copy link
Member

sunchao commented Feb 26, 2024

Merged, thanks!

@advancedxy advancedxy deleted the add_license_header branch February 27, 2024 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants