Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor: refactor prepare_output so that it does not require an ExecutionContext #1194

Merged
merged 1 commit into from
Dec 22, 2024
Merged

minor: refactor prepare_output so that it does not require an ExecutionContext #1194

merged 1 commit into from
Dec 22, 2024

Conversation

andygrove
Copy link
Member

@andygrove andygrove commented Dec 22, 2024 •
edited
Loading

Which issue does this PR close?

N/A

Rationale for this change

This refactor is extracted from #1192.

prepare_output currently requires an ExecutionContext because it calls update_metrics but there is no reason to call update_metrics from within this function.

What changes are included in this PR?

Small refactors:

  • Move update_metrics call out of prepare_output
  • Move update_metrics call out of every match arm in executionPlan and call once before the match

How are these changes tested?

@andygrove andygrove merged commit 58dee73 into apache:main Dec 22, 2024
76 checks passed
@andygrove andygrove deleted the minor-prepare-output branch December 22, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viirya viirya viirya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andygrove @viirya